server: trim autoscale Windows VM hostname #11327

shwstppr · 2025-07-29T10:16:01Z

Description

Fixes #9505

Trim the generated name to take the last 15 characters.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#9505 Signed-off-by: Abhishek Kumar <[email protected]>

codecov · 2025-07-29T10:23:54Z

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.36%. Comparing base (7d59bfe) to head (16240b9).
⚠️ Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
...ava/com/cloud/network/as/AutoScaleManagerImpl.java	66.66%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11327   +/-   ##
=========================================
  Coverage     17.35%   17.36%           
- Complexity    15232    15237    +5     
=========================================
  Files          5885     5886    +1     
  Lines        525618   525694   +76     
  Branches      64157    64163    +6     
=========================================
+ Hits          91225    91269   +44     
- Misses       424094   424124   +30     
- Partials      10299    10301    +2

Flag	Coverage Δ
uitests	`3.63% <ø> (ø)`
unittests	`18.40% <66.66%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-07-30T06:22:40Z

@blueorangutan package

blueorangutan · 2025-07-30T06:24:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-30T08:56:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14463

github-actions · 2025-07-31T11:58:30Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache · 2025-08-25T10:47:55Z

@shwstppr
is this ready for review ?

shwstppr · 2025-08-25T11:02:10Z

@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same.

weizhouapache · 2025-08-25T11:18:31Z

@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same.

@shwstppr
looks ok to me. I could not find a better solution to be honest.

is it possible the first letter is unaccepted (for example -) after the truncation ?

Signed-off-by: Abhishek Kumar <[email protected]>

DaanHoogland · 2025-08-25T13:59:12Z

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

+        if (Character.isLetterOrDigit(hostName.charAt(0))) {
+            return new Pair<>(hostName, name);
+        }
+        String temp = name.substring(0, Math.max(0, name.length() - 15)).replaceAll("[^a-zA-Z0-9]", "");


edge case: all of the last 15 chars are special chars or whitespace. I think we better do a replace first and then take the last 15.

@DaanHoogland I don't think this case can happen.
The only user-defined part in the VM name is the name of the autoscale group, and we've checks for that to only contain letters, numbers and hyphen. checkAutoScaleVmGroupName` does that

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-08-26T04:52:44Z

@blueorangutan package

blueorangutan · 2025-08-26T04:54:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-26T06:53:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14730

weizhouapache · 2025-08-26T07:24:20Z

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

        }
-        return new Pair<>(hostName, displayName);
+        String hostName = name.substring(Math.max(0, name.length() - 15));
+        if (Character.isLetterOrDigit(hostName.charAt(0))) {


it seems digit it not supported as first char ? @shwstppr

cloudstack/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

Lines 4104 to 4109 in 1272b13

public void checkNameForRFCCompliance(String name) {

if (!NetUtils.verifyDomainNameLabel(name, true)) {

throw new InvalidParameterValueException("Invalid name. Vm name can contain ASCII letters 'a' through 'z', the digits '0' through '9', "

+ "and the hyphen ('-'), must be between 1 and 63 characters long, and can't start or end with \"-\" and can't start with digit");

}

}

server: trim autoscale Windows VM hostname

36e636a

Fixes apache#9505 Signed-off-by: Abhishek Kumar <[email protected]>

boring-cyborg bot added the component:networking label Jul 29, 2025

shwstppr added 2 commits July 30, 2025 11:11

fix

0c34a76

Signed-off-by: Abhishek Kumar <[email protected]>

fix imports

aa21706

Signed-off-by: Abhishek Kumar <[email protected]>

github-actions bot added the status:has-conflicts label Jul 31, 2025

Merge remote-tracking branch 'apache/main' into fix-autoscalewinvm

b97ef66

github-actions bot removed the status:has-conflicts label Aug 1, 2025

Merge branch 'main' into fix-autoscalewinvm

4c9de62

shwstppr marked this pull request as ready for review August 25, 2025 11:02

improve

4c9ff4c

Signed-off-by: Abhishek Kumar <[email protected]>

DaanHoogland reviewed Aug 25, 2025

View reviewed changes

return if okay

16240b9

Signed-off-by: Abhishek Kumar <[email protected]>

weizhouapache reviewed Aug 26, 2025

View reviewed changes

harikrishna-patnala added this to the 4.22.0 milestone Sep 3, 2025

harikrishna-patnala added this to Apache CloudStack 4.22.0 Sep 3, 2025

harikrishna-patnala moved this to In Progress in Apache CloudStack 4.22.0 Sep 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

server: trim autoscale Windows VM hostname #11327

server: trim autoscale Windows VM hostname #11327

Uh oh!

shwstppr commented Jul 29, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

shwstppr commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

shwstppr commented Aug 25, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

DaanHoogland Aug 25, 2025

Uh oh!

shwstppr Aug 26, 2025

Uh oh!

shwstppr commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

weizhouapache Aug 26, 2025

Uh oh!

Uh oh!

	public void checkNameForRFCCompliance(String name) {
	if (!NetUtils.verifyDomainNameLabel(name, true)) {
	throw new InvalidParameterValueException("Invalid name. Vm name can contain ASCII letters 'a' through 'z', the digits '0' through '9', "
	+ "and the hyphen ('-'), must be between 1 and 63 characters long, and can't start or end with \"-\" and can't start with digit");
	}
	}

server: trim autoscale Windows VM hostname #11327

Are you sure you want to change the base?

server: trim autoscale Windows VM hostname #11327

Uh oh!

Conversation

shwstppr commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

shwstppr commented Aug 25, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

DaanHoogland Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

weizhouapache Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shwstppr commented Jul 29, 2025 •

edited

Loading

codecov bot commented Jul 29, 2025 •

edited

Loading